fix: form submission when country is not requried #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1099 +/- ##
=======================================
Coverage 86.98% 86.98%
=======================================
Files 124 124
Lines 2266 2267 +1
Branches 624 625 +1
=======================================
+ Hits 1971 1972 +1
Misses 286 286
Partials 9 9
☔ View full report in Codecov by Sentry. |
mphilbrick211
added
the
waiting for eng review
|
Hi @openedx/vanguards! This is ready for review / merge. Thanks! |
|
Thanks, @attiyaIshaque! Are you able to merge this for us? |
|
Hi @attiyaIshaque: could you merge this for us? It's one of the main issues the Quince testing plan raised, so it's crucial for the release. |
|
@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
itsjeyd
removed
the
waiting for eng review
arbrandes
pushed a commit
to arbrandes/frontend-app-authn
that referenced
this pull request
Nov 17, 2023
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
arbrandes
pushed a commit
that referenced
this pull request
Nov 17, 2023
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
snglth
pushed a commit
to Abstract-Tech/community-theme-authn
that referenced
this pull request
Jan 9, 2024
When country is not required to submit, the displayValue check will always return true. This fixes it by only check it if it's needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS` This issue might has been discoverd at edx.org becuase edx.org requires the Country to be filled when creating an account, however this is not the case for Open edX by default, hence the issue reported below Ref: openedx/wg-build-test-release/issues/318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When country is not required to submit, the displayValue check
will always return true. This fixes it by only check it if it's
needed through the config
SHOW_CONFIGURABLE_EDX_FIELDSThis issue might has been discoverd at edx.org becuase edx.org
requires the Country to be filled when creating an account,
however this is not the case for Open edX by default, hence the
issue reported below
Ref: openedx/wg-build-test-release/issues/318
How Has This Been Tested?
Please describe in detail how you tested your changes.
You would need to locally install tutor and tutor-mfe
quincebranch and then try to recreate an account after all services has been inits. And lastly rebuild the MFE image using my fork as a base and you should then be able to create an accountMerge Checklist
Post-merge Checklist